Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpath, linker, compiler flags and find python fixes #153

Merged
merged 3 commits into from
Dec 3, 2020
Merged

rpath, linker, compiler flags and find python fixes #153

merged 3 commits into from
Dec 3, 2020

Conversation

petricm
Copy link

@petricm petricm commented Nov 23, 2020 •
edited by gaede
Loading

resolves #145
resolves #76
BEGINRELEASENOTES

  • Set rpath for macOS and externalize compiler and linker flags
  • Search for the same version of python as was used for building ROOT

ENDRELEASENOTES

the compiler flags are only a suggestion

gaede
gaede approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked nicely on my macbook. Also, activating the compiler warnings is really helpful.

vvolkl
vvolkl reviewed Dec 3, 2020
View reviewed changes
cmake/podioBuild.cmake Outdated Show resolved Hide resolved
@vvolkl
fix typo
bb77c17 
Co-authored-by: vvolkl <valentin.volkl@cern.ch>
@vvolkl vvolkl mentioned this pull request Dec 3, 2020
Closed
8 tasks
@gaede gaede merged commit 97f1fdd into AIDASoft:master Dec 3, 2020
@tmadlener tmadlener mentioned this pull request Dec 9, 2020
Closed
This was referenced Jan 19, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkl vvolkl vvolkl left review comments

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find python issues rpath setup
3 participants
@petricm @vvolkl @gaede