Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Catch2 v3 #206

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Switch to Catch2 v3 #206

merged 4 commits into from
Aug 13, 2021

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Switch to Catch2 v3 test library and by default assume that it is available. Use the 'USE_EXTERNAL_CATCH2` cmake option to control whether podio should use an external installation or if it should fetch and build it internally instead.
  • Remove catch.hpp header that was previously shipped, since it is no longer needed.

ENDRELEASENOTES

@tmadlener
Switch to Catch2 v3 for unittests
c7d51e8 
This makes it possible to build it only once and statically link against
a central version. For now set the default to pull it from github and
build it locally nontheless
@tmadlener
Enable using an external Catch2 by default
3758dea
@tmadlener
Add some clangd tooling to .gitignore
d348f49
@hegner hegner self-requested a review August 13, 2021 14:38
@hegner
Copy link
Collaborator

hegner commented Aug 13, 2021

Looks great. Thanks!
Could you as well update the top level howto? As to list the new potential dependency.

@hegner hegner merged commit 2d36032 into AIDASoft:master Aug 13, 2021
@hegner hegner removed their request for review August 13, 2021 19:41
@hegner hegner mentioned this pull request Aug 13, 2021
Closed
@tmadlener tmadlener deleted the use-catch2-v3 branch August 16, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkl vvolkl vvolkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmadlener @hegner @vvolkl