Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few smaller generation issues (once more) #217

Merged
merged 3 commits into from
Sep 10, 2021

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Make the Obj destructors = default where possible, i.e. if a datatype has no relations to handle
  • Make the assignment operators of the user facing classes use the "copy-and-swap" idiom
  • Fix the problem where OneToOneRelations needed to be from the same namespace as the datatype they are used in (OneToOneRelations can only be used if they are in the same namespace #216)

ENDRELEASENOTES

Fixes #216, fixes #203

Only necessary to be non-default in case of relation handling
Necessary to use OneToOneRelations in a different namespace
Copy link
Collaborator

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the move to swap. if the tests run fine, I will merge :-)

@hegner hegner merged commit c50af75 into AIDASoft:master Sep 10, 2021
@tmadlener tmadlener deleted the fix-template-issues branch September 10, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants