Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame in memory interface #278

Closed
wants to merge 15 commits into from
Closed

Frame in memory interface #278

wants to merge 15 commits into from

Commits on Jun 15, 2022

  1. Add the basic structure for the Frame class

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    13fd72c View commit details
    Browse the repository at this point in the history

  2. Add basic support for GenericParameters through Frame

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    31b4025 View commit details
    Browse the repository at this point in the history

  3. Make Frame a move-only type

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    6441307 View commit details
    Browse the repository at this point in the history

  4. Restrict get/put interfaces to only accept collections

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    07ab566 View commit details
    Browse the repository at this point in the history

  5. Add first version of thread safety and tests 

    Using a mutex to guard the internal map. Not yet a policy with
possibility to disable locking from the outside
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    dc962e1 View commit details
    Browse the repository at this point in the history

  6. Fix non-movable mutex 

    Use a unique_ptr<mutex> to preserve default movability of things
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    50750df View commit details
    Browse the repository at this point in the history

  7. Fix clang-tidy warning

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    fe448ec View commit details
    Browse the repository at this point in the history

  8. Add test case for multithreaded parameter insertion

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    c17a90b View commit details
    Browse the repository at this point in the history

  9. Add mutexes guarding the internal maps for GenericParameters 

    - Make them non-copyable
- Fix read_tests to use const references instead of copying
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    c065551 View commit details
    Browse the repository at this point in the history

  10. Reorganize tests slightly to avoid Catch2 thread problem 

    If REQUIRE is the last statement in a function run on a thread, clangs
ThreadSanitizer triggers in the Catch2 internals.
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    9998197 View commit details
    Browse the repository at this point in the history

  11. Make earlier tests also use the name helper function

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    ad82a34 View commit details
    Browse the repository at this point in the history

  12. Capture thread index instead of passing it as an argument 

    Makes all thread test cases consistent
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    5930792 View commit details
    Browse the repository at this point in the history

  13. Make it possible to put untyped CollectionBase into Frame 

    - Use case came up in k4SimDelphes
    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    72cebdc View commit details
    Browse the repository at this point in the history

  14. Update documentation

    @tmadlener
    tmadlener committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    41b9e50 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Work around Catch2 assertion thread safety issues

    @tmadlener
    tmadlener committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ebc56fb View commit details
    Browse the repository at this point in the history