-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an argument to exclude SIO files from some tests #387
Conversation
Thanks for this. Since I always build everything nowadays, it seems I no longer realize the small issues in switching between with and without SIO. I would do this slightly differently from a conceptual point of view:
This approach would only have one |
- Rework script and CMakeLists to pass in more information in environment - Format CMakeLists for slightly better readability
rebased this onto the latest master and reworked the overall logic slightly to remove a few of the if/else branches. I have tried toggling the |
I'll have a look at this; I found out that in the original version the extension test was not being run correctly (it was the same as the non-extension one) so I need to have a look in detail |
I see now that you fixed that on your last commit. I started working but never pushed it... |
Now it works for non SIO, SIO builds with and without clang-format and also going from non-SIO to SIO and viceversa |
Thanks again for checking. Waiting for the CI before merging. |
* Actually check extension model dumping * Rework script and CMakeLists to pass in more information in environment * Also check when clang format is used --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
BEGINRELEASENOTES
ENABLE_SIO
ENDRELEASENOTES
This allows not to have to cleanup a few folders in
test
in case the SIO files are present, which would break the tests. Useful in case one is switching between SIO and non-SIO for example