Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete square when running cmake #410

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Remove the square that is run when cmake runs

ENDRELEASENOTES

Nothing wrong with it, just annoying to have to scroll through many lines to get to the interesting part of the cmake output. The summary is kept so it looks like this now:

-- Found nlohmann_json: /usr/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found suitable version "3.11.2", minimum required is "3.11.2") 
-- Python version used for building ROOT 3.10.10
-- Required python version 3.10.10
-- Creating 'datamodel' datamodel

  PODIO Data Model
  ================
  Used datalayout.yaml to create 91 classes in /home/jmcarcell/Key4hep/Key4hep-all/podio/tests/
  Read instructions in the README.md to run your first example!

-- Found nlohmann_json: /usr/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found suitable version "3.11.2", minimum required is "3.10") 
-- Found compatible version of JSON library, will add JSON support to test datamodel
-- Not adding the SIO Blocks library to the targets because the corresponding c++ sources have not been generated
-- Creating 'extension_model' datamodel
/home/jmcarcell/Key4hep/Key4hep-all/podio/python/podio_class_generator.py:100: FutureWarning: Please provide a schema_version entry. It will become mandatory. Setting it to 0 as default
  self.datamodel = PodioConfigReader.read(yamlfile, package_name, upstream_edm)

  PODIO Data Model
  ================
  Used datalayout_extension.yaml to create 17 classes in /home/jmcarcell/Key4hep/Key4hep-all/podio/tests/extension_model/
  Read instructions in the README.md to run your first example!

-- Not adding the SIO Blocks library to the targets because the corresponding c++ sources have not been generated
-- Using test inputs stored in: /home/jmcarcell/Key4hep/Key4hep-all/podio/build/test_input_data_vuJYd3sm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is part of the files that are installed, so removing it breaks the installation in some of the CI workflows. We would also have to remove it from the list here:

set(to_install
podio_class_generator.py
podio_schema_evolution.py
figure.txt
EventStore.py)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@hegner
Copy link
Collaborator

hegner commented May 9, 2023

I am actually fine with removing it altogether. Is a nice gimmick though ;-)

@tmadlener tmadlener merged commit b3b06aa into AIDASoft:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants