Add schema evolution hooks to Frame #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
schema-evol-hooks
branch
from
42a55cf
to
213430c
Compare
2 tasks
tmadlener
force-pushed
the
schema-evol-hooks
branch
3 times, most recently
from
a9d2a3f
to
5439699
Compare
Easier this way to get the current version information into the whole system
Remove two step registration again
tmadlener
force-pushed
the
schema-evol-hooks
branch
from
5439699
to
2afde17
Compare
1 task
tmadlener
changed the title
hegner
approved these changes
Jun 27, 2023
| * that the registration still happens on a single thread. After this | ||
| * initialization evolutions can be done from multiple threads. | ||
| */ | ||
| class SchemaEvolution { |
There was a problem hiding this comment.
not sure why you talk about SchemaEvolution and SchemaEvolutionRegistry interchangeably. Maybe one should just make a global (and stupid) rename?
There was a problem hiding this comment.
Removed the registry bits again. They were leftovers from when it was not yet entirely clear to me what the name should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
podio::SchemaEvolutionthat can hold schema evolution functions and that offers anevolveBuffersmethod that does the schema evolution on these buffers before collections are created.podio::Frameto call this when collections are read from the FrameData.ENDRELEASENOTES
This introduces a
podio::SchemaEvolutionregistry that holds schema evolution functions and that offers anevolveBuffersmethod that takespodio::CollectionReadBuffers, a schema version and the type of the collection that will be constructed from these buffers and evolves them to the current schema version (potentially by doing nothing at all). This will not yet introduce any machinery to actually also populate this registry, that will be another PR.TODO: