Make the SIOFrameWriter call to finish non-mandatory #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
approved these changes
Jul 13, 2023
4 tasks
tmadlener
added a commit
that referenced
this pull request
Jul 13, 2023
This reverts commit 6409d58.
|
Could we wait for CI to finish before merging, regardless of how trivial the PR looks, please? This one was missing 654ad98 (I pushed that to master directly now) |
hegner
pushed a commit
to hegner/podio
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
finishfor theSIOFrameWriternon-mandatory. See Allow not callingfinish()when using the writers #442 for other related changes.ENDRELEASENOTES