Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make building SIO tests depend on ENABLE_SIO #457

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Make building SIO tests depend on ENABLE_SIO #457

merged 1 commit into from
Jul 20, 2023

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Simplify the test setup for SIO in CMake and make it explicit on the ENABLE_SIO option rather than on the presence of targets.

ENDRELEASENOTES

@tmadlener tmadlener mentioned this pull request Jul 20, 2023
Merged
4 tasks
@jmcarcell
Copy link
Member

Looks good

@tmadlener tmadlener merged commit 6b8eeb1 into AIDASoft:master Jul 20, 2023
17 of 18 checks passed
hegner pushed a commit to hegner/podio that referenced this pull request Jul 27, 2023
@tmadlener @hegner
Make building SIO tests depend on ENABLE_SIO (AIDASoft#457)
48200f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcarcell jmcarcell jmcarcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @jmcarcell