Fix reading relations to unpersisted objects #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
tmadlener
changed the title
tmadlener
requested review from
hegner and
jmcarcell
and removed request for
hegner
|
This seems to be a breaking change at least for the legacy I/O algorithms in k4FWCore. Should we aim for a smoother migration or do we just merge the two PRs "in sync"? |
tmadlener
force-pushed
the
frame-based-tests
branch
from
1172f27
to
8f06070
Compare
hegner
approved these changes
Sep 22, 2023
Ananya2003Gupta
pushed a commit
to Ananya2003Gupta/podio
that referenced
this pull request
Sep 26, 2023
* Switch test case from EventStore to Frame based I/O * Default initialize ObjectIDs to untracked * Add check for existence before getting collections * Properly lock the collection ID table * Make CollectionIDTable return optional for some queries * Make sure that each category gets its own id table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ObjectIDs to untracked to properly track whether they have been added to a Frame or notCollectionIDTableinterfaces ofnameandcollectionIDto returnoptionalto signal whether a collection (ID) is known to the table. This is a breaking change if you use theCollectionIDTable!ROOTNTupleReaderthat was uncovered by the CollectionIDTable switch to optional returns.ENDRELEASENOTES