Refactor the code generation and split it into language specific generators #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
cleanup-code-gen
branch
2 times, most recently
from
e680f67
to
bc593dc
Compare
2 tasks
tmadlener
commented
Dec 11, 2023
andresailer
reviewed
Dec 11, 2023
|
@hegner does anything speak against merging this? Should make experimenting with julia a bit easier. |
3 tasks
tmadlener
force-pushed
the
cleanup-code-gen
branch
from
5b6a413
to
4c8751d
Compare
- Keep common functionality in the base mixin - Instantiate the correct generator in the main script
tmadlener
force-pushed
the
cleanup-code-gen
branch
from
4c8751d
to
70403a0
Compare
|
Merging this to let the nightlies pick it up before a new tag for the next LCG release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ClassGeneratorinto a base class (mixin) and two specific c++ and julia code generators that only deal with their language specific needs.podio_class_generator.pymain script depending on the desired language.MemberVariableto declutter its__init__method a bit.ENDRELEASENOTES
This resolves the main design issue mentioned in #473 (review)
Apart from implementing the basics for the mixin this is mainly just shuffling code around.