Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check using ROOT_CXX_STANDARD #540

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jan 17, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

currently nightly builds with HEAD of ROOT are not working in the LCG stacks. I think it breaks because of this removal:
root-project/root@d487a42#diff-99952e2ce9de0fe836877b1910798d5d4c60c7c27a62c1b51410643a6a2c9654L180

Building this PR with a ROOT version with ROOT_CXX_STANDARD set is working for me.

@tmadlener
Copy link
Collaborator

Do we already have a check somewhere that makes sure that building podio with c++20 also requires root to have c++20?

@tmadlener
Copy link
Collaborator

@jmcarcell
Copy link
Member Author

I added a check (prints a warning) when the C++ standard is different in ROOT from the required. It could be an error but it was somewhat useful to build some packages with C++20 when we didn't have ROOT with C++20 to see if they failed or not; anyway mismatches can't happen in spack so in user builds there would be a visible warning.

Does this fixe this error? AIDASoft/podio/actions/runs/7555260579/job/20569847736?pr=383#step:4:170

Yes

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Merging this to unblock a few of the other PRs that are essentially ready.

@tmadlener tmadlener merged commit 139d89b into AIDASoft:master Jan 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants