Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ROOTNTuple{Reader,Writer} to RNTuple{Reader,Writer} #543

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jan 22, 2024

BEGINRELEASENOTES

  • Change ROOTNTuple{Reader,Writer} to RNTuple{Reader,Writer}

ENDRELEASENOTES

So it's clear it's RNTuple (ROOT also has NTuples. An alternative would be removing ROOT and having simply RNTuple{Reader, Writer}, I guess when there is an interface it won't matter much.

@tmadlener
Copy link
Collaborator

I actually like RNTuple{Reader,Writer} a bit more then with ROOT. I suppose it is sufficiently clear that we talk about the RNTuple from ROOT. However, I am not sure how much work that would create for #522 in the end, so if you want to avoid that I am also happy just keeping ROOTRNTuple.

@jmcarcell jmcarcell changed the title Change ROOTNTuple{Reader,Writer} to ROOTRNTuple{Reader,Writer} Change ROOTNTuple{Reader,Writer} to RNTuple{Reader,Writer} Jan 22, 2024
@jmcarcell
Copy link
Member Author

It's OK, it takes only a moment

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

Let's clarify during the meetings tomorrow and Wednesday, whether we need some sort of backward compatibility for a migration period, or whether we can just press the button as it is.

@jmcarcell
Copy link
Member Author

It should be quite safe to merge. Probably I'm the only one who has been using these writers and readers...

@tmadlener tmadlener merged commit 9656cef into AIDASoft:master Jan 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants