Remove unnecessary usage of TClass from RNTupleReader #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
jmcarcell
reviewed
Jan 30, 2024
| const auto collectionClass = TClass::GetClass(m_collectionInfo[category].type[i].c_str()); | ||
|
|
||
| auto collection = | ||
| std::unique_ptr<podio::CollectionBase>(static_cast<podio::CollectionBase*>(collectionClass->New())); |
There was a problem hiding this comment.
No, not really per se. It has just become unnecessary with the introduction of our own buffer factory. Now it was only used to get the type name basically, which we already have available otherwise.
jmcarcell
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
TClassmachinery inside theRNTupleReaderas all the necessary information is also available from metadata that we carry around in any case.ENDRELEASENOTES