Move templates under python #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes introduced by AIDASoft#54 caused installs to fail due to the change in location of the templates directory relative to python/. Following discussion in AIDASoft#58, implement simplest possible change to fix by moving templates inside the python directory. Retain this layout at install time, adjusting the `template_dir` variable in podio_class_generator.py accordingly. Fixes: AIDASoft#58
|
Thanks for fixing this. Please write in the future some short comment inside the BEGINRELEASENOTES/ENDRELEASENOTES. These will show up in the ReleaseNots.md when we make release tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced by #54 caused installs to fail due to the change in location of the templates directory relative to python/.
Following discussion in #58, implement simplest possible change to fix by moving templates inside the python directory. Retain this layout at install time, adjusting the
template_dirvariable inpodio_class_generator.py accordingly.
Fixes: #58
BEGINRELEASENOTES
templatesinside thepythondirectory when installing- fixes: EDM generation broken after install #58
ENDRELEASENOTES