Remove dynamic determination of supported parameter types for python bindings #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
changed the title
tmadlener
force-pushed
the
fix-podio-dump-type-det
branch
from
49dcd65
to
1a2f6d9
Compare
|
I have replaced the dynamic determination with a hardcoded map of types since this will not change very frequently and the code that does the determination is effectively c++ template meta programming with python syntax, which makes maintenance harder than the newly introduced map. |
tmadlener
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
std.tuple_elementnot working on macOS root-project/root#14232 and EDM4hep does not seem to work on MacOS key4hep/EDM4hep#246.ENDRELEASENOTES
Given that the GenericParameter types that we support probably doesn't change very frequently we could also consider keeping the "hardcoded" map as the only implementation and document that this needs to be updated in case the supported parameter types are changed. The current code for determining it is quite a mouthful and I am not sure it's more maintainable than having to update this map manually.