add cmake doc #607
Merged
add cmake doc #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #604 |
tmadlener
reviewed
May 24, 2024
There was a problem hiding this comment.
I think this should also mention the additional arguments that are available from PODIO_GENERATE_DATAMODEL. At least the UPSTREAM_EDM (with a pointer to EDM4eic potentially) and the LANG arguments.
The DEPENDS one is at least touched upon at the datamodel syntax introduction.
I also think this has to be added to doc/index.rst at an appropriate place.
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
|
What do you think about adding a link to macro definitions in podioMacros.cmake for reference? In other projects sometimes they put their user-facing cmake macros in some obscure places and I wish they simply put a link in docs to save me from greping everything 😅 |
tmadlener
reviewed
May 27, 2024
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
tmadlener
reviewed
May 31, 2024
andresailer
reviewed
Jun 3, 2024
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
|
Should we merge this now and add the advanced usage in another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES