Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass an argument by const reference instead of value and other minor fixes #633

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 23, 2024

BEGINRELEASENOTES

  • Minor cleanups for generated EDMs
    • Pass the argument by const reference in the relation setter
    • Remove a few includes that are not needed
    • Don't check for nullptr before deleting a (possibly nullptr) pointer
    • Remove if - else check and use implicit conversion of pointer to bool

ENDRELEASENOTES

@tmadlener
Copy link
Collaborator

Looks like CERNs infrastructure is slightly overwhelmed, CI is failing because we cannot get cvmfs or because fetching test data is failing.

@m-fila
Copy link
Contributor

m-fila commented Jun 24, 2024

Another minor fix that could be added:
this could be simiplified to just return m_obj

bool {{ full_type }}::isAvailable() const {
if (m_obj) {
return true;
}
return false;
}

@tmadlener
Copy link
Collaborator

Can you pick up the changes from #634 (i.e. merge / rebase onto latest master)? I think that should fix the remaining CI issues that we see.

@jmcarcell
Copy link
Member Author

Can you pick up the changes from #634 (i.e. merge / rebase onto latest master)? I think that should fix the remaining CI issues that we see.

Done

@tmadlener tmadlener merged commit 1b6c811 into AIDASoft:master Jun 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants