use enable_if to allow using containers of interfaces with object wrappers #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
force-pushed
the
interface_constructor_select
branch
2 times, most recently
from
956c6b9
to
e1657b2
Compare
tmadlener
reviewed
Sep 23, 2024
m-fila
force-pushed
the
interface_constructor_select
branch
from
adae820
to
3ac6d7b
Compare
tmadlener
approved these changes
Sep 26, 2024
jmcarcell
reviewed
Sep 26, 2024
|
EDM4hep CI failures should be fixed with #690 |
tmadlener
force-pushed
the
interface_constructor_select
branch
from
d9a0c07
to
a1dfb3f
Compare
|
I am going to merge this as soon as CI passes. Just to be sure: This one is not immediately needed in a tag, right? Because the discussion that triggered this is still open / not finally settled in k4FWCore either. |
|
Yes, I think it should be fine to tag it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
key4hep/k4FWCore#238 I spotted that the containers of interface types can't be used in stock
Gaudi::Functionalalgorithms (unlike containers of data types) due to instantiating wrong constructor from the template.The problem was vector's direct initialization with
{std::vector<interface_type>&&}would call the interface type constructor withstd::vector<interface_type>&&(failing late due to the assert) rather than vector's constructor. Withenable_ifthe correct overload is chosen due to SFINAE