Introduce a new links category for the YAML definitions
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
links-in-yaml
branch
3 times, most recently
from
59cfd7b
to
f89ff67
Compare
Open
5 tasks
|
From a technical point of view this is ready. I can successfully build the complete stack with this and key4hep/EDM4hep#373 without any changes to the stack, apart from a few cases where the deprecated |
tmadlener
force-pushed
the
links-in-yaml
branch
from
c796d07
to
b004e7a
Compare
tmadlener
commented
Oct 9, 2024
Add the new category so that it can be read
Effectively a header per link with a typedef and a common .cc file with registration code for all links
Otherwise things start to break in cases where users explicitly use these types at the moment.
tmadlener
force-pushed
the
links-in-yaml
branch
from
a8cb251
to
f5cbd4d
Compare
tmadlener
commented
Oct 17, 2024
|
@peremato this should also address your concerns about having to discover these links for the Julia interface, I think. Now they will just be listed as a separate category in the YAML file, and you should have all the necessary information again to generate the necessary code, I think. |
tmadlener
commented
Oct 17, 2024
Comment on lines
+552
to
+555
| self._write_file( | ||
| "DatamodelLinkSIOBlock.cc", | ||
| self._eval_template("DatamodelLinksSIOBlock.cc.jinja2", link_data), | ||
| ) |
There was a problem hiding this comment.
This needs to be behind an if statement and should only be generated in case SIO as actually enabled as a backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
linkscategory into the YAML grammar to automate the declaration of Links.ENDRELEASENOTES
Diff wrt to #257
As can be seen from the diff above, I needed to change the definition of the
PODIO_DECLARE_LINKmacro, and it now only deals with the registration to theCollectionBufferFactoryand there is a separate macro to deal with the registration to theSIOBlockFactory. Otherwise, it becomes hard to only build the "central" part of a datamodel without any dependencies on an I/O backend. This could be lifted to #257 if we wanted.