Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericParameters.h: add missing clear and empty check for double map #692

Merged
merged 1 commit into from
Sep 30, 2024
Merged

GenericParameters.h: add missing clear and empty check for double map #692

merged 1 commit into from
Sep 30, 2024

Conversation

Zehvogel
Copy link
Contributor

just saw this while scrolling through. I have not checked if it is also missing in more places

BEGINRELEASENOTES

  • GenericParameters.h: added missing clear and empty check for double map

ENDRELEASENOTES

@m-fila
Copy link
Contributor

m-fila commented Sep 27, 2024

It doesn't seem to be missing anywhere else.

tmadlener
tmadlener approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Seems like I missed this when we added the doubles.

@tmadlener tmadlener merged commit 8651fdd into AIDASoft:master Sep 30, 2024
18 checks passed
@Zehvogel Zehvogel deleted the patch-1 branch September 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zehvogel @m-fila @tmadlener