Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if a non-existent product is required #97

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Jun 10, 2020

Minimal solution to fix #96

@tmadlener tmadlener mentioned this pull request Jun 29, 2020
7 tasks
@gaede
Copy link
Contributor

gaede commented Aug 4, 2020

It would be better to throw an exception in this case ...

@tmadlener tmadlener changed the title [WIP] notify user if a non-existent product is required Throw an exception if a non-existent product is required Aug 11, 2020
@gaede gaede merged commit b087578 into AIDASoft:master Sep 4, 2020
tmadlener added a commit to tmadlener/podio that referenced this pull request Sep 4, 2020
tmadlener added a commit to tmadlener/podio that referenced this pull request Sep 8, 2020
tmadlener added a commit to tmadlener/podio that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podio silently skips over non-existant products
2 participants