Implement a Driver connection type #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes TypeScript a bit more bearable.
We are using the Aedes broker library. Create a broker and perform auth on clients. The broker URL to listen on and the location of the passwords for the drivers are taken from the environment rather than from the config as these will need to be synchronised with the driver deployment. This means they are Helm values rather than edge agent config items.
The messages from a driver are too complicated to try to emit as positional arguments; emit an object instead. This means we can pull out and validate the data topic name too.
These tasks are too small to go in Jira, and some will probably outlive this project.
Device represents a Sparkplug Device, and clearly lives on the Edge Agent side of the divide. It should not have any connection-specific functionality. Where there was specific code, this was concerned with arranging to subscribe to addresses on the southbound connection. Handle this in the Connection class instead.
This sits alongside the other connection types, for now, and speaks my new driver protocol. This doesn't handle CMDs or errors correctly yet, but otherwise works. I'm not entirely sure how to handle drivers that want to poll themselves. Currently the EA keeps sending poll messages regardless, and drivers like OPCUA can just not subscribe, and use the group poll instruction instead. I have disabled the watchdog timeout; it fires much too quickly when you're pretending to be a device manually. I'm not sure a fixed timeout with no ping is the right thing to do anyway; there are valid reasons why a connection might not speak for 10s.
AlexGodbehere
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sits alongside the other connection types (for now) and communicates with an external driver using the new protocol.
Configuration, polling and data packets are implemented. Command packets and error handling is not.
The Device subclasses have been removed. Where they had functionality this has been moved into the DeviceConnections. The Devices now purely handle the Sparkplug side of things, leaving the DeviceConnection to handle the southbound details.