generated from AMRC-FactoryPlus/acs-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Namespace #341
Open
AlexGodbehere
wants to merge
61
commits into
main
Choose a base branch
from
dn-uns-ingester
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unified Namespace #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bun does not support Node-API for GSSAPI.js
A new .env.example file has been added to the ingesters/sparkplug directory. This example file contains placeholder environment variables necessary for the function of the Sparkplug Ingester.
The import statements in ingester.ts and mqttclient.ts have been changed to import ServiceClient and UUIDs from "@amrc-factoryplus/service-client" instead of "@amrc-factoryplus/utilities". The dependence in package.json was also updated accordingly. Additionally, the environment variable 'env' is now being used in ServiceClient's initialization.
This update works out where to publish metrics based on their specified values in Device_Information-v1/Hierarchy-v1. If this doesn't exist, or it's not in the correct location it will be ignored.
Revised the arguments for node commands to ensure correct script execution in the uns.yaml, sparkplug.yaml, and Dockerfile files. Replaced "bin/injector.js" with "app.js" or appropriate script names.
AlexGodbehere
commented
Sep 6, 2024
Extend SparkplugIngester permissions to include CmdEsc.Rebirth. This change allows the service account to issue rebirth requests in addition to its existing read permission.
amrc-benmorrow
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to ask: is it really a good idea to record everything into Influx again from the UNS? Would it not be better just to attach the ISA95 tags to the data from within the ordinary Sparkplug ingester?
amrc-benmorrow
requested changes
Oct 2, 2024
amrc-benmorrow
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the concept of UNS Ingesters, which take channels of data (in this case, Sparkplug), and publishes the human-readable content to
UNS/v1
. This PR includes the required permissions, pricipals and changes to the values file.It also includes a new UNS Historian (
historian-uns
) to persist the UNS topics to InfluxDB and renames thesparkplug-influxdb-ingester
tohistorian-sparkplug
.