Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Namespace #341

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Unified Namespace #341

wants to merge 61 commits into from

Conversation

AlexGodbehere
Copy link
Contributor

@AlexGodbehere AlexGodbehere commented Sep 6, 2024

This PR adds support for the concept of UNS Ingesters, which take channels of data (in this case, Sparkplug), and publishes the human-readable content to UNS/v1. This PR includes the required permissions, pricipals and changes to the values file.

It also includes a new UNS Historian (historian-uns) to persist the UNS topics to InfluxDB and renames the sparkplug-influxdb-ingester to historian-sparkplug.

djnewbould and others added 30 commits July 1, 2024 09:58
Bun does not support Node-API for GSSAPI.js
A new .env.example file has been added to the ingesters/sparkplug directory. This example file contains placeholder environment variables necessary for the function of the Sparkplug Ingester.
The import statements in ingester.ts and mqttclient.ts have been changed to import ServiceClient and UUIDs from "@amrc-factoryplus/service-client" instead of "@amrc-factoryplus/utilities". The dependence in package.json was also updated accordingly. Additionally, the environment variable 'env' is now being used in ServiceClient's initialization.
This update works out where to publish metrics based on their specified values in Device_Information-v1/Hierarchy-v1. If this doesn't exist, or it's not in the correct location it will be ignored.
Revised the arguments for node commands to ensure correct script execution in the uns.yaml, sparkplug.yaml, and Dockerfile files. Replaced "bin/injector.js" with "app.js" or appropriate script names.
Extend SparkplugIngester permissions to include CmdEsc.Rebirth. This change allows the service account to issue rebirth requests in addition to its existing read permission.
Copy link
Contributor

@amrc-benmorrow amrc-benmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to ask: is it really a good idea to record everything into Influx again from the UNS? Would it not be better just to attach the ISA95 tags to the data from within the ordinary Sparkplug ingester?

acs-manager/get-keytab.sh Show resolved Hide resolved
acs-service-setup/dumps/uns.yaml Outdated Show resolved Hide resolved
acs-service-setup/lib/uuids.js Show resolved Hide resolved
historian-uns/src/app.ts Outdated Show resolved Hide resolved
uns-ingester-sparkplug/bin/ingester.js Outdated Show resolved Hide resolved
uns-ingester-sparkplug/bin/ingester.js Outdated Show resolved Hide resolved
uns-ingester-sparkplug/bin/ingester.js Outdated Show resolved Hide resolved
uns-ingester-sparkplug/bin/ingester.js Outdated Show resolved Hide resolved
uns-ingester-sparkplug/lib/mqttclient.ts Outdated Show resolved Hide resolved
acs-service-setup/dumps/uns.yaml Outdated Show resolved Hide resolved
acs-service-setup/lib/uuids.js Outdated Show resolved Hide resolved
deploy/templates/auth/principals/service-clients.yaml Outdated Show resolved Hide resolved
deploy/templates/auth/principals/service-clients.yaml Outdated Show resolved Hide resolved
deploy/templates/auth/principals/service-clients.yaml Outdated Show resolved Hide resolved
deploy/values.yaml Outdated Show resolved Hide resolved
@AlexGodbehere AlexGodbehere marked this pull request as ready for review October 10, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants