Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the meson version in the cache keys #2252

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add the meson version in the cache keys #2252

merged 2 commits into from
Jul 11, 2024

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Jul 11, 2024

No description provided.

@vrabaud vrabaud requested a review from wantehchang July 11, 2024 12:31
@vrabaud
Copy link
Collaborator Author

vrabaud commented Jul 11, 2024

E.g., the https://github.com/AOMediaCodec/libavif/actions/runs/9891435279/job/27321852165?pr=2252 CI gives:

Cache not found for input keys: deps-Linux-X64-build-shared-local--37182331cb2576a444df073acd2f13521500d04795c0df3c9668991c0322b92c-1.3.2

wantehchang
wantehchang reviewed Jul 11, 2024
View reviewed changes
.github/actions/cache/action.yml Outdated Show resolved Hide resolved
.github/actions/cache/action.yml Show resolved Hide resolved
.github/actions/cache/action.yml Outdated Show resolved Hide resolved
.github/actions/cache/action.yml Outdated Show resolved Hide resolved
.github/actions/cache/action.yml Outdated Show resolved Hide resolved
@vrabaud
Copy link
Collaborator Author

vrabaud commented Jul 11, 2024

And we get:
https://github.com/AOMediaCodec/libavif/actions/runs/9891928986/job/27323410187?pr=2252

Cache not found for input keys: deps-Linux-X64-build-shared-local--meson-1.3.2-37182331cb2576a444df073acd2f13521500d04795c0df3c9668991c0322b92c

https://github.com/AOMediaCodec/libavif/actions/runs/9891928990/job/27323410157?pr=2252

Cache not found for input keys: deps-Windows-X64-build-windows-installed--meson-none-7032e832ebbacac7781b6a8cd4d6450e83d6df7168abb4b3f035c69a8f21fbcf

wantehchang
wantehchang approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vrabaud vrabaud merged commit 2ea07bc into AOMediaCodec:main Jul 11, 2024
13 checks passed
@vrabaud vrabaud deleted the ci_meson branch July 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrabaud @wantehchang