Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance]:Replace-deperacted-OnWillPopScope-with-PopScope #294

Conversation

kareemabdeen
Copy link
Contributor

@kareemabdeen kareemabdeen commented Mar 11, 2024

Description

Now, instead of using the deprecated OnWillPopScope, you can simply use PopScope to achieve the same functionality in a more efficient and future-proof way,
also Refactored save changes Dialog as separated function in the app utils files to be separated from the ui code

Fixes #270

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

with my emulator

Please include screenshots below if applicable.
here is how app functions after the changes had done
https://github.com/AOSSIE-Org/Resonate/assets/118139061/ced336de-b05b-4af5-8386-18b1bd84f220

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

…imple refactore for saveChangesDialogue function to be in appUtils file with other dialogues
@kareemabdeen kareemabdeen changed the title Enhance]:Replace-deperacted-OnWillPopScope-with-PopScope ,This change will ensure your code remains up-to-date and follows best practices for Flutter new version best practices . Enhance]:Replace-deperacted-OnWillPopScope-with-PopScope Mar 11, 2024
@chandansgowda chandansgowda added the good first issue Good for newcomers label Mar 12, 2024
@kareemabdeen
Copy link
Contributor Author

@chandansgowda if there's any problem on the branch please let me know

@Aarush-Acharya
Copy link
Contributor

Aarush-Acharya commented May 10, 2024

Hey @kareemabdeen, This is good to merge will merge once the PR prior to this are resolved

@Aarush-Acharya Aarush-Acharya added attended This PR was attended by a Reviewer IMS duplicate This issue or pull request already exists and removed IMS labels May 10, 2024
@Aarush-Acharya
Copy link
Contributor

Hey @kareemabdeen this is already taken care of in #274

@vrundraval24
Copy link
Contributor

Hey, @Aarush-Acharya
It is a duplicate, but the original PR has some conflicts and the contributor is not responding so I am merging this.
I am removing the duplicate tag and also closing the original PR without merging.

Good work @kareemabdeen 🚀

@vrundraval24 vrundraval24 added enhancement New feature or request IMS and removed duplicate This issue or pull request already exists labels May 23, 2024
@vrundraval24 vrundraval24 merged commit 2150446 into AOSSIE-Org:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attended This PR was attended by a Reviewer enhancement New feature or request good first issue Good for newcomers IMS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning: Replace WillPopScope with PopScope
4 participants