Add new requirements to code generation of CMSE Entry function and Non-secure calls #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-secure calls This addresses the vulnerability described in CVE-2024-0151. Patch by Victor Campos. Co-authored-by: Victor Campos <victor.campos@arm.com>
ostannard
reviewed
Apr 30, 2024
… and Non-secure calls - Reword requirement 47 and 58. - Replace "guidance" by "recommendation". - Rework example from requirement 47 to use a global array instead of one passed as argument.
ostannard
reviewed
May 22, 2024
| bxns lr | ||
| ``` | ||
|
|
||
| We recommend that function parameters with integral types smaller than 4 |
There was a problem hiding this comment.
What is the reason for this recommendation? Are there other potential problems with small types, or is this because there are existing compilers which don't follow these rules?
There was a problem hiding this comment.
The latter. There are a lot of older compilers out there that won't or can't be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the vulnerability described in CVE-2024-0151.
Patch by Victor Campos.
Co-authored-by: Victor Campos victor.campos@arm.com