Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phonyfiles refactor #671

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Phonyfiles refactor #671

merged 12 commits into from
Oct 10, 2023

Conversation

lukokr-aarch64
Copy link
Contributor

No description provided.

@lukokr-aarch64
chore: make dependentInterface also require file
77434c3 
This change makes all modules which match the dependentInterface
also be file.Provider in preparation to remove dependentInterface
and its methods.

Change-Id: I95c45aba5084b0c2907334de983048db35629fe2
@lukokr-aarch64
chore: shared lib install test
ae9f4dc 
Change-Id: I89cfd6fa37b808944024bd7766e4b5a70e14c9c5
@lukokr-aarch64
feat(file): allow adding additional tags on links
c15f4f0 
The link object itself may need to be tagged with
additional types, such as implicit when creating
shared libraries.

Change-Id: I998e5c9ac3ed2bea724a25c71501701e29b7e0cb
@lukokr-aarch64
feat(file): add common filters for outfiles
e10fe70 
These helper methods can replace the following methods:
- `implicitOutputs`
- `outputs`
- `filesToInstall`

Change-Id: If25119ab4b39f823f08adfedb6977f77ce82d6da
@lukokr-aarch64
refactor: remove unused functions
a3c8336 
`getHeadersGenerated` and `getSourcesGenerated` are no longer
used anywhere. Removed.

Change-Id: Ie76c06f8c412ca2c3ed304d3332c25ab8a8da5ad
@lukokr-aarch64
refactor: remove filesToInstall
fa71180 
This is no longer needed as the file
interface supports installable tag.

Change-Id: Ifa6015f07f037172eb45aac489639f3cb1ae148f
@lukokr-aarch64
refactor: standardise implicitOutputs
f4941be 
All modules will not use a standard implemenation,
this will allow the removal of `implicitOutputs`.

Change-Id: I69304b319ceecbc1bd60ea677d7be3ecc9ac56dd
@lukokr-aarch64
refactor: remove implicitOutputs
80ea0c4 
Change-Id: Ic5b3946025b22e85832eb80802d6f3e3d3f55451
@lukokr-aarch64
fix: remove implicit files from getPhonyFiles
791f5bc 
Since implicit files are not listed as the rule output, it
does not make sense to include them in phony files which
require a rule to build them.

Change-Id: I79aef9d1758b8b06eec76c225aeef7c60aee82a1
@lukokr-aarch64
refactor: standardise outputs()
b5c2a5a 
Prepare to remove `outputs` method by switching
all modules to use the file interface common
implementation.

This commit adds both library varianets to phony
rule for `bob_library`.
When gathering generated dep files, exclude
implicits. All targets that are required from
a generator should be explicitly listed.

Change-Id: Ic67abc0940e2ca3fc20dac926c0ec5fbf22c8544
@lukokr-aarch64
refactor: remove outputs()
59916e4 
This is now replaced with the `file.Provider`
interface.

Change-Id: Ibc247fdd7f490a411ccd04f102c9161a63be65c5
@lukokr-aarch64
refactor: remove getPhonyFiles
cd81471 
All phony targets should use `GetOutputs` instead.

Change-Id: Ide89fab2c901f82c3935521a07a46be9c31f2912
@github-actions
Copy link

LCOV of commit cd81471 during CI #500

Summary coverage rate:
  lines......: 34.9% (4534 of 12995 lines)
  functions..: no data found
  branches...: 62.0% (556 of 897 branches)

Files changed coverage rate:
                                                 |Lines       |Functions  |Branches    
  Filename                                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================================
  core/binary.go                                 | 0.0%     27|    -     0|    -      0
  core/build_structs.go                          | 0.0%    386|    -     0|    -      0
  core/external_library.go                       | 0.0%     82|    -     0|    -      0
  core/file/file.go                              |82.0%    100|    -     0|    -      0
  core/file/file_test.go                         | 100%    105|    -     0|    -      0
  core/file/provider.go                          | 0.0%     12|    -     0|    -      0
  core/gen_binary.go                             | 0.0%     35|    -     0|    -      0
  core/gen_library.go                            | 0.0%     82|    -     0|    -      0
  core/gen_shared.go                             | 0.0%     55|    -     0|    -      0
  core/gen_static.go                             | 0.0%     45|    -     0|    -      0
  core/generated.go                              | 0.0%    141|    -     0|    -      0
  core/generated_common.go                       | 0.0%    275|    -     0|    -      0
  core/install.go                                | 0.0%    221|    -     0|    -      0
  core/kernel_module.go                          | 0.0%    172|    -     0|    -      0
  core/library.go                                | 0.0%    554|    -     0|    -      0
  core/library_shared.go                         | 0.0%     74|    -     0|    -      0
  core/library_static.go                         | 0.0%     22|    -     0|    -      0
  core/linux_backend.go                          | 2.1%    191|    -     0|    -      0
  core/linux_cclibs.go                           | 0.6%    468|    -     0|    -      0
  core/linux_generated.go                        | 0.0%    194|    -     0|    -      0
  core/linux_kernel_module.go                    | 0.0%     37|    -     0|    -      0
  core/module_generate_source.go                 | 0.0%     90|    -     0|    -      0
  core/module_genrule.go                         | 0.0%    103|    -     0|    -      0
  core/module_gensrcs.go                         | 0.0%    105|    -     0|    -      0
  core/module_transform_source.go                | 0.0%     91|    -     0|    -      0
  core/strict_binary.go                          | 0.0%     20|    -     0|    -      0
  core/strict_library.go                         | 0.0%    250|    -     0|    -      0

@lukokr-aarch64 lukokr-aarch64 enabled auto-merge (rebase) October 10, 2023 09:05
@lukokr-aarch64 lukokr-aarch64 merged commit 7f51a8b into master Oct 10, 2023
32 checks passed
@lukokr-aarch64 lukokr-aarch64 deleted the phonyfiles_refactor branch October 10, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birunts birunts birunts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukokr-aarch64 @birunts