Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag forward #673

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Tag forward #673

merged 2 commits into from
Oct 11, 2023

Conversation

lukokr-aarch64
Copy link
Contributor

No description provided.

@lukokr-aarch64
chore(bob_toolchain): add tag test case
82bde1a 
Change-Id: Ifac50926780ef0da23b499bfcfc096a3b6ee1b03
@lukokr-aarch64
feat: forward tags from bob_toolchain
b9e6928 
Currently only the `owner:` tag is used within Bob,
for this reason this is the only tag currently forwarded
in the backend.

Should a need for wider tag forwarding arise this will
require changes to `Tagable` interface to retrieve the
property from direct deps via the toolchain tag.

Care must be taken as this can result in duplicate
tags, which will produce an error in the case of `owner:`.

Change-Id: I514f06138fd6d5b9ba9fa7402c50af42a42ecf06
@lukokr-aarch64 lukokr-aarch64 enabled auto-merge (rebase) October 11, 2023 11:56
@github-actions
Copy link

LCOV of commit b9e6928 during CI #506

Summary coverage rate:
  lines......: 35.1% (4588 of 13073 lines)
  functions..: no data found
  branches...: 62.0% (556 of 897 branches)

Files changed coverage rate:
                                                 |Lines       |Functions  |Branches    
  Filename                                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================================
  core/androidbp_backend.go                      | 0.0%    318|    -     0|    -      0
  core/androidbp_cclibs.go                       | 3.0%    596|    -     0|    -      0
  core/androidbp_filegroup.go                    | 0.0%      7|    -     0|    -      0
  core/androidbp_kernel_module.go                | 0.0%     75|    -     0|    -      0
  core/androidbp_resource.go                     | 0.0%     81|    -     0|    -      0

@lukokr-aarch64 lukokr-aarch64 merged commit 0b84197 into master Oct 11, 2023
32 checks passed
@lukokr-aarch64 lukokr-aarch64 deleted the tag_forward branch October 11, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birunts birunts birunts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukokr-aarch64 @birunts