Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new mbed-os-example-attestation example #10031

Merged
merged 4 commits into from
Mar 12, 2019
Merged

Add new mbed-os-example-attestation example #10031

merged 4 commits into from
Mar 12, 2019

Conversation

adbridge
Copy link
Contributor

Description

New example added to example list for CI testing

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

Release Notes

@adbridge adbridge requested review from alekshex and a team March 11, 2019 11:40
orenc17
orenc17 suggested changes Mar 11, 2019
View reviewed changes
tools/test/examples/examples.json Outdated
"K66F",
"NUCLEO_F429ZI",
"UBLOX_ODIN_EVK_W2",
"LPC55S69"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPC55S69_NS

@0xc0170 0xc0170 requested a review from a user March 11, 2019 11:53
@adbridge
Copy link
Contributor Author

ci started

alekshex
alekshex reviewed Mar 11, 2019
View reviewed changes
tools/test/examples/examples.json
"UBLOX_ODIN_EVK_W2",
"LPC55S69_NS"
],
"toolchains" : [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be empty?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If no toolchain is specified, it will use all three.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference the above examples.

@adbridge
Copy link
Contributor Author

ci needed restarting, now done

@cmonr
Copy link
Contributor

cmonr commented Mar 11, 2019

@adbridge @ARMmbed/mbed-os-psa

Making sure, is the example repo still suppose to be public by now?

@mbed-ci
Copy link

mbed-ci commented Mar 11, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2019

Marked as ready, final approval from @ChiefBureaucraticOfficer

Making sure, is the example repo still suppose to be public by now?

and this ^^

ghost
ghost approved these changes Mar 11, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets criteria, PSA. Approved.

@ghost ghost added the PM_ACCEPTED label Mar 11, 2019
@cmonr cmonr merged commit 7661d2d into ARMmbed:master Mar 12, 2019
@cmonr cmonr removed the needs: work label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@orenc17 orenc17 orenc17 approved these changes

@alekshex alekshex alekshex approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adbridge @cmonr @mbed-ci @0xc0170 @NirSonnenschein @orenc17 @alekshex