Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: Fix ble gattserver autorization list registration #10094

Merged
merged 1 commit into from
Mar 29, 2019
Merged

BLE: Fix ble gattserver autorization list registration #10094

merged 1 commit into from
Mar 29, 2019

Conversation

desmond-blue
Copy link
Contributor

Description

This is for #10028, GattServer maintains an authorization list which is registered by attribute permission check, UPDATE_PROPERTIES which equals NOTIFY_PROPERTY | INDICATE_PROPERTY is not a correct permission check.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desmond-blue desmond-blue changed the title Fix ble gattserver autorization list registration BLE: Fix ble gattserver autorization list registration Mar 14, 2019
@ciarmcom ciarmcom requested review from a team March 14, 2019 10:00
@ciarmcom
Copy link
Member

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

pan-
pan- requested changes Mar 14, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that change isn't correct. We need to cache characteristic that send update as we consult the getUpdateSecurityRequirement latter.

@desmond-blue desmond-blue force-pushed the fix_ble_gattserver_autorization_list branch from 65b2a49 to 196a766 Compare March 15, 2019 04:12
@desmond-blue
Copy link
Contributor Author

Hi @pan- , got it, then I believe the condition check for update properties should be changed from
attribute_it->permissions & UPDATE_PROPERTIES
to
properties & UPDATE_PROPERTIES

@adbridge
Copy link
Contributor

@desmond-blue Any updates on this pr ?

@desmond-blue
Copy link
Contributor Author

@pan- I've done some changes on original commit, could you check if it's good? Thanks.

@cmonr cmonr requested a review from pan- March 28, 2019 01:57
pan-
pan- approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desmond-blue thanks.

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@alekla01
Copy link
Contributor

restarted jenkins-ci/mbed-os-ci_greentea-test

@cmonr cmonr merged commit eef1b48 into ARMmbed:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@pan- pan- pan- approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@desmond-blue @ciarmcom @adbridge @cmonr @mbed-ci @alekla01 @pan-