BLE SimpleAdvertisingBuilder moved functions out of mbed_assert calls

[marcemmers]

Description

I had an issue where advertising stopped working in release mode when using this code:

    ble::AdvertisingDataSimpleBuilder<0x1F> advertisingBuilder;

    advertisingBuilder.setFlags( GapAdvertisingData::BREDR_NOT_SUPPORTED | GapAdvertisingData::LE_GENERAL_DISCOVERABLE );
    advertisingBuilder.setName( DEVICE_NAME );
    advertisingBuilder.setLocalService( SERVICE_UUID, false );

Found out that the functions setFlags and setName were optimized away. This is caused by the functions are internally calling functions inside an mbed_assert call resulting in a nop when NDEBUG is defined.

I moved the function calls out of the mbed_assert calls and checked the result later.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

[ciarmcom]

@marcemmers, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

[cmonr]

Nice find!

[cmonr]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

[pan-]

Thanks for the fixes.