examples test compile optional verbose #10301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alekla01, thank you for your changes. |
tools/test/examples/examples_lib.py
Outdated
| @@ -391,7 +391,7 @@ def compile_repos(config, toolchains, targets, profile, examples): | |||
| valid_choices(example['toolchains'], toolchains), | |||
| example['features']): | |||
| print("Compiling %s for %s, %s" % (name, target, toolchain)) | |||
| build_command = ["mbed-cli", "compile", "-t", toolchain, "-m", target, "-v"] | |||
| build_command = ["python", "-m", "mbed", "compile", "-t", toolchain, "-m", target] + (['-v'] if verbose else []) | |||
There was a problem hiding this comment.
This change is not explained in the commit message or in the Pull Request description. Could you please explain why you added python -m to the beginning of this command?
0xc0170
approved these changes
Apr 4, 2019
theotherjimmy
approved these changes
Apr 4, 2019
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
|
@adbridge I would like your review for this changeset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add examples test compile verbose cmd argument.
Pull request type
Reviewers
Release Notes