Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow toolchain paths to be wrapped in quotes #10333

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Allow toolchain paths to be wrapped in quotes #10333

merged 1 commit into from
Apr 9, 2019

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Apr 5, 2019

Description

Fixes ARMmbed/mbed-cli#875. This allows you to specify toolchain paths with quotes surrounding the location (ex MBED_ARM_PATH="C:\path\to\toolchain")

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@theotherjimmy

@bridadan bridadan mentioned this pull request Apr 5, 2019
Closed
@ciarmcom ciarmcom requested review from theotherjimmy and a team April 5, 2019 21:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 5, 2019

@bridadan, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

theotherjimmy
theotherjimmy approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existence check is also going to complicate things when multiple paths are provided.

@bridadan
Copy link
Contributor Author

bridadan commented Apr 5, 2019

The existence check is also going to complicate things when multiple paths are provided.

Not sure what you mean, are you talking about multiple paths within the quotes?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 905042e into ARMmbed:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bridadan @ciarmcom @0xc0170 @mbed-ci @theotherjimmy @cmonr