Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 readme update #13513

Merged
merged 1 commit into from
Sep 1, 2020
Merged

STM32 readme update #13513

merged 1 commit into from
Sep 1, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Adding more information about mbed-os STM32 specific implementations.

@ARMmbed/team-st-mcd

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 31, 2020
@ciarmcom ciarmcom requested a review from a team August 31, 2020 10:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 requested changes Aug 31, 2020
View reviewed changes
targets/TARGET_STM/README.md Outdated
```
==> You can use PA_5 pin as SPI, **only** if your application is not using LED...

Sometimes, pin is explictly removed by default to avoid issues (but you can uncomment the line for your custom board)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly

targets/TARGET_STM/README.md Outdated
- If your application is using PC_10 pin for UART, drivers will configure UART3 instance.
- If your application is using PC_10_ALT0 pin for UART, drivers will configure UART4 instance.

Same alternate choice feature is also used for PWM, ADC, SPI, etc...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jeromecoutant jeromecoutant mentioned this pull request Aug 31, 2020
Closed
@0xc0170 0xc0170 self-requested a review August 31, 2020 13:02
@mergify mergify bot added needs: CI and removed needs: work labels Aug 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Aug 31, 2020

Command refresh: success

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

Rule: remove outdated reviews (dismiss_reviews) — action 'dismiss_reviews' failed

I can't find out what caused this failure with Mergify. It seems refresh did not help.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

Once CI completes, I'll try to close and reopen the PR.

@0xc0170 0xc0170 closed this Aug 31, 2020
@mergify mergify bot removed ready for merge release-type: patch Indentifies a PR as containing just a patch labels Aug 31, 2020
@0xc0170 0xc0170 reopened this Aug 31, 2020
@0xc0170 0xc0170 added ready for merge release-type: patch Indentifies a PR as containing just a patch labels Aug 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

Once Travis completes, I'll merge this. I am not able to fix mergify. If I find one more PR affected, I'll report this to mergify team (don't have enough data so far).

@0xc0170 0xc0170 merged commit 4ef38f9 into ARMmbed:master Sep 1, 2020
@mergify mergify bot removed the ready for merge label Sep 1, 2020
@jeromecoutant jeromecoutant deleted the PR_README branch September 1, 2020 07:53
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LMESTM LMESTM LMESTM approved these changes

Assignees
No one assigned
Labels
release-version: 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @ciarmcom @0xc0170 @LMESTM @mbedmain