-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM FM: refactor CMake targets #14246
Conversation
3fbed8d
to
511ad6e
Compare
@0xc0170, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename CMake target names to follow the convention so they are picked up by CMake.
511ad6e
to
bfb36b6
Compare
Rebased, fixed the naming. |
Pull request has been modified.
@@ -106,6 +35,4 @@ target_sources(mbed-core | |||
drivers/lan91c111.c | |||
|
|||
SDK/fpga.c | |||
${SYSTEM_FILE} | |||
${STARTUP_FILE} | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link mbed-fvp-mps2
with mbed-arm-fm
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M0/CMakelists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M0/CMakelists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M0P/CMakelists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M3/CMakelists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M4/CMakelists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M7/CMakelists.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugues Kamba-Mpiana <41612201+hugueskamba@users.noreply.github.com>
Fixed all comments |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the files from CMakelists.txt to CMakeLists.txt
Fixed all names |
Pull request has been modified.
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
CMake targets follow Mbed OS targets structure.
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers