Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: remove workaround for targets prior refactor #14286

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 15, 2021

Summary of changes

As we refactored all targets, we can remove this workaround from the tree. This should be in the upcoming release

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


As we refactored all targets, we can remove this workaround from the tree.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 15, 2021
@ciarmcom ciarmcom requested a review from a team February 15, 2021 14:30
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 15, 2021

Once #14289 gets in, this is ready!

@mergify mergify bot added needs: CI and removed needs: review labels Feb 16, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 16, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 16, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 8bdc626 into ARMmbed:master Feb 16, 2021
@mergify mergify bot removed the ready for merge label Feb 16, 2021
@0xc0170 0xc0170 deleted the cmake-fix-remove-target-workaround branch February 16, 2021 14:46
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants