-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bare metal support to ARM_MPS2_Target family of targets #14300
Conversation
@harmut01, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments apply to all scatter files.
targets/TARGET_ARM_SSG/TARGET_MPS2/TARGET_MPS2_M0/device/TOOLCHAIN_ARM_STD/MPS2.sct
Outdated
Show resolved
Hide resolved
targets/TARGET_ARM_SSG/TARGET_MPS2/TARGET_MPS2_M0/device/TOOLCHAIN_ARM_STD/MPS2.sct
Outdated
Show resolved
Hide resolved
#define RAM_FIXED_SIZE (MBED_CONF_TARGET_BOOT_STACK_SIZE + VECTOR_SIZE) | ||
|
||
#define MBED_RAM1_START (MBED_RAM_START + VECTOR_SIZE) | ||
#define MBED_RAM1_SIZE (MBED_RAM_SIZE - VECTOR_SIZE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not match was there before as the size of :
RW_IRAM1 (0x20000000+0x100) (0x400000-0x100-Stack_Size) {
Now:
RW_IRAM1 MBED_RAM1_START MBED_RAM1_SIZE {
Should it be:
RW_IRAM1 MBED_RAM1_START (MBED_RAM1_SIZE-MBED_CONF_TARGET_BOOT_STACK_SIZE)
Is there a reason you changed it? Did you find it was incorrect? Can you double check with the MUSCA team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake, I was trying to preserve the hard coded values. What seems to have changed is that in the original MBED_RAM1_SIZE = MBED_RAM_SIZE - MBED_CONF_TARGET_BOOT_STACK_SIZE - VECTOR_SIZE
(which is equal to what you've suggested), although I thought RAM1 includes the fixed boot stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some boards have subtleties that are not always documented. So it is probably better to have a clear reason to change them if we are changing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is that region size calculated for the GCC_ARM toolchain linker file?
@hugueskamba I've made the requested changes, I'm still a little uncertain about the RAM1 size calculation but I think my modifications preserve the original hard coded values. |
targets/TARGET_ARM_SSG/TARGET_MPS2/TARGET_MPS2_M0P/device/TOOLCHAIN_ARM_STD/MPS2.sct
Outdated
Show resolved
Hide resolved
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Modify ARM_MPS2_Target target configuration to include bare metal as a supported profile, and add list of supported standard libraries. Remove hard coded values from the scatter files so that they are consistent with other targets. Changes affect the following targets: ARM_MPS2_M0, ARM_MPS2_M0P, ARM_MPS2_M3, ARM_MPS2_M4, and ARM_MPS2_M7.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers