Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STM32XX] Fix default build #2098

Merged
merged 1 commit into from
Jul 22, 2016
Merged

[STM32XX] Fix default build #2098

merged 1 commit into from
Jul 22, 2016

Conversation

svastm
Copy link
Contributor

@svastm svastm commented Jul 5, 2016 •
edited
Loading

A lot of ST targets are defined with a default_build: "small" and a default_toolchain: "uARM". It allow to use only one thread in the RTOS.

This commit make the st targets with less than 64KB of FLASH use the small build and uARM. The ones with FLASH >= 64KB use ARM and standard build.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,GCC_ARM,IAR
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Jul 5, 2016

[Build 582]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2016

@svastm There was one PR changing the target.json file, there are conflicts now, please can you rebase? Should be simple conflicts (one flag was added to json file per target)

@svastm svastm force-pushed the switch_default_build branch 2 times, most recently from e1781c1 to e1dcc27 Compare July 7, 2016 07:42
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,GCC_ARM,IAR
TARGETS=ALL

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2016 •
edited
Loading

cc @screamerbg this will affect users, happy with this? Is there any mechanism we can use to notify or at least document that this has changed?

@mbed-bot
Copy link

[Build 626]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 15, 2016

The tests results are OK. Waiting for +1 from @screamerbg

@0xc0170 0xc0170 removed the needs: CI label Jul 21, 2016
@screamerbg
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,GCC_ARM,IAR
TARGETS=ALL

@screamerbg
Copy link
Contributor

+1
Can you rebase? Then we will re-test.

@svastm
Copy link
Contributor Author

svastm commented Jul 21, 2016

@screamerbg rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,GCC_ARM,IAR
TARGETS=ALL

@mbed-bot
Copy link

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

@mbed-bot
Copy link

[Build 661]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,GCC_ARM,IAR
TARGETS=ALL

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2016 •
edited
Loading

[Build 661]

@screamerbg Tests results are ok for ARM, there was some failures for other toolchains for L053R8, but that is not connected to this changeset. If you are happy with this change, please merge

@mbed-bot
Copy link

[Build 667]
FAILURE: Something went wrong when building and testing.

@screamerbg
Copy link
Contributor

Thanks @svastm @0xc0170

@screamerbg screamerbg merged commit c8a5aae into ARMmbed:master Jul 22, 2016
@svastm svastm deleted the switch_default_build branch July 29, 2016 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svastm @0xc0170 @mbed-bot @screamerbg