Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools-build,make,test] Disallow parent of repo as --build args #2142

Merged
merged 2 commits into from
Jul 22, 2016

Conversation

theotherjimmy
Copy link
Contributor

Resolves #2081 by making any parent of the repo (or the repo dir itself)
passed to --build fail at argument parsing time.

@theotherjimmy
Copy link
Contributor Author

cc: @0xc0170 @bridadan @sg-

@screamerbg
Copy link
Contributor

+1

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F

@bridadan
Copy link
Contributor

@theotherjimmy Running the bot on it quickly just to make sure nothing unexpected pops up.

Would you mind adding this to test.py as well?

@theotherjimmy
Copy link
Contributor Author

NP. Just a moment.

@mbed-bot
Copy link

[Build 628]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@bridadan
Copy link
Contributor

+1!

@sg- sg- merged commit f817ec1 into ARMmbed:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants