Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force installation of dependencies in entry points #2257

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jul 26, 2016

Entry points affected:

  • build.py
  • make.py
  • test.py
  • project.py

They will install every dependency within requirements.txt that cannot be found with pkg_resources.working_set.require

@sg-
Copy link
Contributor

sg- commented Jul 27, 2016

@screamerbg please review

@screamerbg
Copy link
Contributor

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 30, 2016

One question @theotherjimmy : what's the time profile for this change? How much does it take per invocation ?

Plus, I am not certain this is what is expected from a python module? I mean setup.py is an entry point, however, if we consider these tools not to have that entry point, then there should be a consumer of these tools where those req should be (dependencies) and they should follow what python modules do, you install them prior a use, or at least quick check. and a user do what is required - install via pip, install as an egg, virtualenv, etc..
How does it solve the dependency versions? I dont see that here

@screamerbg
Copy link
Contributor

@0xc0170 the impact shouldn't be significant as pip install -r requirements.txt is only invoked if modules are missing. @theotherjimmy perhaps reload(site) should be part of the pip install... rather than applied every time, e.g. even if the modules are okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants