Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nRF5x uart hardware flow control configuration using mbed configuration systsem #2535

Merged
merged 1 commit into from
Aug 25, 2016
Merged

nRF5x uart hardware flow control configuration using mbed configuration systsem #2535

merged 1 commit into from
Aug 25, 2016

Conversation

nvlsianpu
Copy link
Contributor

Introduce uart hardware flow control configuration using mbed configuration system for MCU_NRF51_UNIFIED and MCU_NRF52 targets.

The target.uart_hwfc key is used to configure flow control for nRF5x SoC.

Related to issues:
#2474
#2489
ARMmbed/mbed-os-example-ble#25

This was referenced Aug 24, 2016
Closed
Closed
0xc0170
0xc0170 reviewed Aug 24, 2016
View reviewed changes
hal/targets/hal/TARGET_NORDIC/TARGET_NRF5/serial_api.c
// expected the macro from mbed configuration system
#ifndef MBED_CONF_NORDIC_UART_HWFC
#define MBED_CONF_NORDIC_UART_HWFC NRF_HWFC_ENABLED
#warning None of UART flow control configuration. RTSCTS flowe control is used by default .
Copy link
Contributor

@0xc0170 0xc0170 Aug 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo in flowe

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2016

@nvlsianpu Please squash to one commit or provide better commit message for the second commit.
Why did you decide to go with NRF_HWFC_DISABLED/ENABLED vs NRF_HWFC ? there're macros in targets that are defined in sources. If we have NRF_HWFC that is 0 for disabled , 1 for enabled?

I'll run some CI jobs.

@nvlsianpu
Copy link
Contributor Author

something_disable/enable is a self-expleinig phrase - that why.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=GCC_ARM,GCC_CR
TARGETS=NRF51_DK,NRF51_MICROBIT

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

[Build 833]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 694

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2016

Thanks for the update, please notify us if there are any changes to a pull request

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 708

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2016

Tests are OK, not related to this changeset. all NRF51x are good

@sg- sg- merged commit 39310b2 into ARMmbed:master Aug 25, 2016
@sg- sg- mentioned this pull request Aug 25, 2016
Closed
sg- added a commit that referenced this pull request Aug 27, 2016
@sg-
Merge pull request #2555 from ytsuboi/master
5c14cb9 
[TY51822r3] a patch for TY51822r3 to use a change of PR #2535
0xc0170 pushed a commit that referenced this pull request Aug 30, 2016
@ytsuboi @0xc0170
a patch for TY51822r3 to use a change of PR #2535
a7694ba
@nuket nuket mentioned this pull request Aug 30, 2016
Closed
0xc0170 pushed a commit that referenced this pull request Aug 31, 2016
@ytsuboi @0xc0170
a patch for TY51822r3 to use a change of PR #2535
2339beb
miklis pushed a commit that referenced this pull request Sep 12, 2016
@ytsuboi
[TY51822r3] a patch for TY51822r3 to use a change of PR #2535
08709e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvlsianpu @0xc0170 @mbed-bot @sg-