Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in greentea-client for uvisor-tests-standalone integration #2702

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Changes in greentea-client for uvisor-tests-standalone integration #2702

merged 1 commit into from
Sep 19, 2016

Conversation

mazimkhan
Copy link

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

Changes in greentea-client API to support uVisor standalone test framework. Enables PR https://github.com/ARMmbed/uvisor-tests-standalone/pull/2

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

List related PRs against other branches:
https://github.com/ARMmbed/uvisor-tests-standalone/pull/2

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

@mazimkhan
Copy link
Author

mazimkhan commented Sep 14, 2016 •
edited
Loading

requires ARMmbed/htrun#128
may fails testing.

@mazimkhan
Copy link
Author

retest

@bridadan
Copy link
Contributor

@sg- @0xc0170 @bogdanm Just to be clear, this isn't ready to merge until a new version of htrun/greentea is released. So please hold off on merging for the time being

bridadan
bridadan reviewed Sep 14, 2016
View reviewed changes
features/frameworks/greentea-client/greentea-client/test_env.h
@@ -75,6 +75,8 @@ extern const char* GREENTEA_TEST_ENV_LCOV_START;
*/
void GREENTEA_SETUP(const int, const char *);
void GREENTEA_TESTSUITE_RESULT(const int);
void GREENTEA_TESTCASE_START(const char *test_case_name);
void GREENTEA_TESTCASE_FINISH(const char *test_case_name, const size_t passes, const size_t failed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these two functions always had an implementation in greentea-client, they were just never exposed via test_env.h?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. That's because of these functions were declared extern in utest and called due to some circular dependency.

@bridadan
Copy link
Contributor

@mazimkhan Besides the thoughts I posted, the changes seem sane to me!

@bridadan bridadan mentioned this pull request Sep 14, 2016
Merged
@bridadan
Copy link
Contributor

Forgot to confirm, does this change break with the current released version of htrun?

@mazimkhan
Copy link
Author

mazimkhan commented Sep 15, 2016 •
edited
Loading

@bridadan yes it will break with current htrun version as that has a \n in the K,V regex. ARMmbed/htrun#128 fixes that.

@mazimkhan
Copy link
Author

@sg- @0xc0170 @bogdanm htrun 1.1.2 released. Please merge this PR as it is required for uVisor testing ARMmbed/uvisor-tests-standalone#2

@mazimkhan
Copy link
Author

retest

@bogdanm bogdanm merged commit 65ffa8c into ARMmbed:master Sep 19, 2016
@jeromecoutant
Copy link
Collaborator

Hi
It seems that IPV4 tests can not be OK any more after that merge...?

@sg-
Copy link
Contributor

sg- commented Sep 19, 2016

@jeromecoutant can you share details of which?

@bogdanm no morph CI or mbed-bot on this??

@jeromecoutant
Copy link
Collaborator

Hi

Before this commit, end of each mbed OS test are like this:
[1474292373.29][CONN][RXD] {{end;success}}
[1474292373.29][CONN][INF] found KV pair in stream: {{end;success}}, queued...
[1474292373.29][HTST][INF] __notify_complete(True)
[1474292373.29][HTST][INF] test suite run finished after 3.73 sec...
[1474292373.29][CONN][INF] received special even '__host_test_finished' value='True', finishing
[1474292373.29][HTST][INF] CONN exited with code: 0
[1474292373.29][HTST][INF] No events in queue
[1474292373.29][HTST][INF] stopped consuming events
[1474292373.29][HTST][INF] host test result() call skipped, received: True
[1474292373.29][HTST][WRN] missing __exit event from DUT
[1474292373.29][HTST][INF] calling blocking teardown()
[1474292373.29][HTST][INF] teardown() finished
[1474292373.29][HTST][INF] {{result;success}}

Now, it becomes a timeout:

[1474292737.79][CONN][RXD] {{end;success}}
[1474292737.81][CONN][RXD] {{__exit;0}}
[1474292792.90][HTST][INF] test suite run finished after 60.00 sec...
[1474292792.90][CONN][INF] received special even '__host_test_finished' value='True', finishing
[1474292792.91][HTST][INF] CONN exited with code: 0
[1474292792.91][HTST][INF] No events in queue
[1474292792.91][HTST][INF] stopped consuming events
[1474292792.91][HTST][INF] host test result(): None
[1474292792.91][HTST][WRN] missing __exit event from DUT
[1474292792.91][HTST][ERR] missing __exit event from DUT and no result from host test, timeout...
[1474292792.91][HTST][INF] calling blocking teardown()
[1474292792.91][HTST][INF] teardown() finished
[1474292792.91][HTST][INF] {{result;timeout}}

@bridadan
Copy link
Contributor

bridadan commented Sep 20, 2016 •
edited
Loading

@jeromecoutant Sorry for the inconvenience, there was a slight change to the testing communication library.

Could you please run the following command?

pip install -U mbed-host-tests

artokin added a commit to artokin/mbed-os that referenced this pull request Dec 2, 2021
@artokin
Squashed 'connectivity/nanostack/sal-stack-nanostack/' changes from 2…
791d7fd 
…25a4af..154db5425e

154db5425e Merge branch 'release_internal' into release_external
dca258c3f0 Updated unit test
89df990e6d Set EAPOL relay state function to LLC as a callback
47d8f42bf5 Removed extra call to supplicant delete callback
00ebfd905f Added new configuration options for Border router
421f6a8191 Move RPL code to the 6lr state machine
e1e43b8ac2 Corrected pae controller BR EUI-64 flagging
aaefdaebab Refactored pae controller (ARMmbed#2707)
b82e0ee19a Update copyright text in CMakeLists.txt files (ARMmbed#2706)
5791a22d37 Renamed bootstrap files and separated pae controller callback functions (ARMmbed#2703)
4e3ec07caf MAC beacon payload max MTU allocation limited to for support MTU size 127.
a997ab6653 Iotthd 4698 (ARMmbed#2702)
e64b057bff Adjusted security protocols timeouts (ARMmbed#2701)
cb3db6419f Return invalid values from old API if new configuration is used
6872401f8d RPL address registration update
90a434d318 RPL DAO lifetime update
e39f6432eb Forward RPL configuration unmodified
58da4d6c93 Sync Cmake updates from Mbed OS (ARMmbed#2697)
4c229b46c9 Adjust Wi-SUN host/router config - HAVE_RPL (ARMmbed#2696)
40bd2320ba Update release v15.0.0 details to CHANGELOG (ARMmbed#2694)

git-subtree-dir: connectivity/nanostack/sal-stack-nanostack
git-subtree-split: 154db5425eb9f0df82ee081cb05e7d80cda11415
artokin added a commit to artokin/mbed-os that referenced this pull request Dec 8, 2021
@artokin
Squashed 'connectivity/nanostack/sal-stack-nanostack/' changes from 2…
00253cb 
…25a4af..154db5425e

154db5425e Merge branch 'release_internal' into release_external
dca258c3f0 Updated unit test
89df990e6d Set EAPOL relay state function to LLC as a callback
47d8f42bf5 Removed extra call to supplicant delete callback
00ebfd905f Added new configuration options for Border router
421f6a8191 Move RPL code to the 6lr state machine
e1e43b8ac2 Corrected pae controller BR EUI-64 flagging
aaefdaebab Refactored pae controller (ARMmbed#2707)
b82e0ee19a Update copyright text in CMakeLists.txt files (ARMmbed#2706)
5791a22d37 Renamed bootstrap files and separated pae controller callback functions (ARMmbed#2703)
4e3ec07caf MAC beacon payload max MTU allocation limited to for support MTU size 127.
a997ab6653 Iotthd 4698 (ARMmbed#2702)
e64b057bff Adjusted security protocols timeouts (ARMmbed#2701)
cb3db6419f Return invalid values from old API if new configuration is used
6872401f8d RPL address registration update
90a434d318 RPL DAO lifetime update
e39f6432eb Forward RPL configuration unmodified
58da4d6c93 Sync Cmake updates from Mbed OS (ARMmbed#2697)
4c229b46c9 Adjust Wi-SUN host/router config - HAVE_RPL (ARMmbed#2696)
40bd2320ba Update release v15.0.0 details to CHANGELOG (ARMmbed#2694)

git-subtree-dir: connectivity/nanostack/sal-stack-nanostack
git-subtree-split: 154db5425eb9f0df82ee081cb05e7d80cda11415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mazimkhan @bridadan @jeromecoutant @sg- @bogdanm