Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Add documentation generation script #2911

Merged
merged 9 commits into from
Oct 6, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Oct 4, 2016

Description

Generate documentation at the touch of a command line invocation.

Status

READY

Migrations

RTFM. (NO)

Reviews

Steps to test or reproduce

python tools/misc/docs_gen.py from the mbed-os root

@@ -126,3 +128,5 @@ class AnalogIn {
#endif

#endif

/** @}*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this documentation be on the end brace of the matching namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My script did not automatically find the close-brace of the namespace, and doing so without having a proper parser would be difficult. (I just used a regexp)

@theotherjimmy
Copy link
Contributor Author

mbed-docs.zip

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

I might be missing something, but docs_gen.py does not appear to be in this PR (nor in master).

@screamerbg screamerbg changed the title [Tools] Add docementation generation script [Tools] Add documentation generation script Oct 4, 2016
@screamerbg
Copy link
Contributor

@theotherjimmy Can you add the script to tools/misc/ (not tools root) please?

@screamerbg
Copy link
Contributor

LGTM for the record

@theotherjimmy
Copy link
Contributor Author

@screamerbg Yes. New commit coming.

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

Welp GitHub just didn't show it in the "files changed" tab. I can see it if I review each commit individually.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generation script is currently names docs_get.py, but from your PR comment it sounds like it was meant to be named docs_gen.py. Also, running it gives me the following error:

$ python tools/misc/docs_get.py
Traceback (most recent call last):
  File "tools/misc/docs_get.py", line 32, in <module>
    from tools.toolchains.gcc import GCC_ARM
ImportError: No module named tools.toolchains.gcc

Sounds like you need to add a different directory to the python PATH?

@theotherjimmy theotherjimmy force-pushed the docs-generation branch 2 times, most recently from 6425424 to 4f00d47 Compare October 4, 2016 16:42
@theotherjimmy
Copy link
Contributor Author

@bridadan try now

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After installing doxygen and getting it into my path, everything seems to have worked (with a bunch of warnings, but still ok!)

@theotherjimmy Part of me thinks we should run the bots on this too, just in case some weird syntax error creeped in? Thoughts?

@jupe
Copy link
Contributor

jupe commented Oct 4, 2016

could you configure travis/other CI to generate docs..

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

Not sure how useful that is? I guess just to make sure that doc generation doesn't break?

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

/morph test

@jupe
Copy link
Contributor

jupe commented Oct 4, 2016

at least it doesn't break if we can verify it with CI, that is minimum requirements if you ask from me :). But what I mean that we could upload doxygen documentation directly to S3/XX when PR lands to release branch --> automate documentation generation flow for example.... ;)

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

/morph test

@theotherjimmy
Copy link
Contributor Author

@sg- it no longer touches the excluded header files.

@mbed-bot
Copy link

mbed-bot commented Oct 4, 2016

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

@theotherjimmy
Copy link
Contributor Author

mbed-docs.zip

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1053

All builds and test passed!

@screamerbg
Copy link
Contributor

Ping @geky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants