Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set flags for default_lib = small #2991

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Properly set flags for default_lib = small #2991

merged 1 commit into from
Oct 13, 2016

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Oct 11, 2016

Use newlib nano for targets which have the key "default_lib" set to "small". Also support the legacy key of "default_build".

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 11, 2016

/morph test

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 11, 2016

CC: @theotherjimmy @screamerbg @sg-

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

@theotherjimmy
Copy link
Contributor

Looks good to me. I may move this code out of the toolchains in the future.

0xc0170
0xc0170 approved these changes Oct 12, 2016
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@c1728p9
Properly set flags for default_lib = small
9f6b346 
Use newlib nano for targets which have the key "default_lib" set to
"small". Also support the legacy key of "default_build".
@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 13, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 13, 2016

/morph test

@mbed-bot
Copy link

[Build 1033]
FAILURE: Something went wrong when building and testing.

@sg-
Copy link
Contributor

sg- commented Oct 13, 2016

Failure unrelated.

Scan: TARGET_NUMAKER_PFM_NUC472
Compile [  1.7%]: aes_alt.c
[Error] aes_alt.c@25,0:  #5: cannot open source input file "mbedtls/config.h": No such file or directory
"C:\Jenkins\workspace\mbed-2-build-library\targets\TARGET_NUVOTON\TARGET_NUC472\crypto\aes\aes_alt.c", line 25: Error:  #5: cannot open source input file "mbedtls/config.h": No such file or directory
C:\Jenkins\workspace\mbed-2-build-library\targets\TARGET_NUVOTON\TARGET_NUC472\crypto\aes\aes_alt.c: 0 warnings, 1 error

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

Test failed!

@sg-
Copy link
Contributor

sg- commented Oct 13, 2016

@bridadan help!

@bridadan
Copy link
Contributor

bridadan commented Oct 13, 2016 •
edited
Loading

@sg- Test failures (from morph) should be OK, this is an issue with the htrun tool. 👍

I'm also extremely tired of seeing this issue pop up, so I'll try and work on a patch for this today.

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=ALL

@mbed-bot
Copy link

[Build 1035]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

mbed 2 bot is from currently failing Nuvoton board. Changes look ok 👍

@sg- sg- merged commit 9f74038 into ARMmbed:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@c1728p9 @mbed-bot @theotherjimmy @bridadan @sg- @0xc0170