Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doxygen template #4450

Merged
merged 4 commits into from
Jun 9, 2017
Merged

Doxygen template #4450

merged 4 commits into from
Jun 9, 2017

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Jun 5, 2017 •
edited by sg-
Loading

Status

READY

Related PRs

#4425

branch PR
doxygen-template [https://github.com/deepikabhavnani/mbed-os/tree/doxygen-template]

Todos

sg-
sg- reviewed Jun 6, 2017
View reviewed changes
Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but need to revert the merge commit c4029a9d0a21f002c9143ebd7180163e1478bd72 👍

@sg- sg- added needs: CI and removed needs: work labels Jun 8, 2017
sg-
sg- suggested changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All /// \cond OPERATOR_FUCNTIONS and \endocnd changes should align with existing comments.

@sg-
Copy link
Contributor

sg- commented Jun 8, 2017

Not sure where 9514ef9 came from but should be removed

@deepikabhavnani
Copy link
Author

I did checkout+merge to master branch for my remote repository fork to align them to master mbed-os -> that is when 9514ef943314d650a6b07b2444831c26d6e5e997 came in. Something wrong in flow?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2017 •
edited
Loading

I did checkout+merge to master branch for my remote repository fork to align them to master mbed-os -> that is when 9514ef9 came in. Something wrong in flow?

@deepikabhavnani Please use rebase (merge commits are unnecessary in this case).

@sg- sg- merged commit 52fde55 into ARMmbed:master Jun 9, 2017
@deepikabhavnani deepikabhavnani deleted the doxygen-template branch June 9, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg- sg- sg- approved these changes

Assignees
No one assigned
Labels
release-version: 5.5.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepikabhavnani @sg- @0xc0170 @adbridge