Add common hardware alocator for nRF5x TWI and SPI instances #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
requested changes
Jun 12, 2017
| @@ -87,6 +89,11 @@ typedef struct { | |||
| nrf_drv_spis_t slave; | |||
| } sdk_driver_instances_t; | |||
|
|
|||
| typedef struct { | |||
| uint8_t hw_idx; | |||
| @@ -219,6 +239,18 @@ static nrf_drv_spis_event_handler_t const m_slave_event_handlers[SPIS_COUNT] = { | |||
| #endif | |||
| }; | |||
|
|
|||
| static sdk_driver_instances_t const * get_driver_pattern(uint8_t hw_idx) { | |||
| int8_t idx = instance_hw_idx_get(HW_RESOURCE_SPI); | ||
|
|
||
| if (idx < 0) | ||
| { |
This fix the issue 4357: NRF52 doesn't support simultaneous use of I2C and SPI. Now this resources are reserved by each of hal driver using shared_hw module.
|
@0xc0170 Could you rereview? |
0xc0170
reviewed
Jun 21, 2017
| Intention is to have different policies for peripheral types with shares the same resources. | ||
| Thanks to that, maximum numbers of peripheral instances will be available. | ||
| */ | ||
| static const uint8_t m_serch_policy[] = {SERCH_ASCCENDING, SERCH_DESCCENDING}; |
There was a problem hiding this comment.
typo - ascending /descending?
| static uint8_t m_reservation = 0; | ||
|
|
||
|
|
||
| int8_t instance_hw_idx_get(hw_resource_type_t peripheral_type) { |
| { | ||
| MBED_ASSERT(idx < SHARED_INSTANCES_CNT); | ||
|
|
||
| m_reservation &= (1 << idx); |
There was a problem hiding this comment.
shouldnt you negate the number to return it to 0 ? As the above is setting it to 0?
|
@pan- want to review this one? |
|
Please see my comments at #4357 This change appears to be a serious regression. Even when assigning a single I2C bus (no SPI), "i2c->write(address, NULL, 0)" is returning 0 for any value of address. |
|
@nvlsianpu could you please let us know whether you are able to reproduce the problems? |
|
As this has serious bug - after discussion we provide fix in quite different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Support for sharing resources between SPI and TWI instancess.
This fix the issue #4357: NRF52 doesn't support simultaneous use of I2C and SPI.
Now this resources are reserved by each of hal driver using shared_hw module.
Status
READY