STM32: F1 GPIO: Enable AFIO clock #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is required to enable AFIO clock before using __HAL_AFIO_REMAP_xy macros, which was missing here. Without clocks enable, the remap actually doesn't occur. This would possibly cause some PIOs (part of PB_3, PB_4, PA_13, PA_14, PA_15) to not behave as expected. In most cases AFIO clock was enabled in stm_pin_SetAFPin function, so that this bug was not visible. But there were few cases left were stm_pin_DisconnectDebug would be called first. A typical case was with GCC_ARM in case a DigitalInOut variable is declared as global.
0xc0170
approved these changes
Aug 21, 2017
|
retest uvisor |
|
/morph test |
|
retest uvisor |
|
uvisor retest |
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is required to enable AFIO clock before using __HAL_AFIO_REMAP_xy
macros, which was missing here. Without clocks enable, the remap
actually doesn't occur. This would possibly cause some PIOs (part of
PB_3, PB_4, PA_13, PA_14, PA_15) to not behave as expected.
In most cases AFIO clock was enabled in stm_pin_SetAFPin function, so
that this bug was not visible. But there were few cases left were
stm_pin_DisconnectDebug would be called first. A typical case was
with GCC_ARM in case a DigitalInOut variable is declared as global.
Status
READY
Tests
Few MBED2 tests were failing on GCC_ARM/IAR before the fix.
Now: