-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge common files between LPC11XX and LPC11CXX #79
Conversation
Use #if DEVICE_CAN for can_s definition
Merge back into spi_api.c. P0_10/SPI_0 (SWCLK) now disabled for both targets
Merge back into analog_api.c. P1_3/ADC0_4 (SWDIO) now disabled for both targets
Because CT32B1 (P1_1, P1_2 and P1_3) is used by us_ticker.c for wait and ticker function. Since wait/ticker is commonly used by mbed code and I decided CT32B1 of LPC11XX should only be used for this function, not for PwmOut. P1_6 and P1_7 are used by UART (USBTX/USBRX) and I think they should not be assigned to other function.
I prefer an idea by mbednotifications here: The pinname.h should have SWDIO/SWCLK PinName (e.g. P0_10), but peripheral apis use them if DEVICE_SWD_PINS_AVAILABLE is defined (=1 in device.h). Any comment on this? |
Will create a new pull request including pwm_api.c (as well as fixing a typo in the last commit message) |
In general I would not like to see pinnames removed or disabled just because From: mbed-devel@googlegroups.com [mailto:mbed-devel@googlegroups.com] On what's the reason that P1_6, P1_7, P1_1, P1_2, P1_3 are removed in LPC11XX? Because CT32B1 (P1_1, P1_2 and P1_3) is used by us_ticker.c for wait and P1_6 and P1_7 are used by UART (USBTX/USBRX) and I think they should not be The SWDIO/SWCLK definition can be the same for both targets: Would it be an I prefer an idea by mbednotifications here: #74 (comment) The pinname.h should have SWDIO/SWCLK PinName (e.g. P0_10), but peripheral Any comment on this? Reply to this email directly or view it You received this message because you are subscribed to the Google Groups |
Note that the LPC11C24 has a few pins missing since they are taken up by the can tranceiver that's built into the chip. I could see that disabling the SWD pins could make sense to prevent bricking, but it would be nice if that could be changed with a simple option in device.h, maybe the same for the serial pins. |
A warning at compile time would be nice. |
Add lifetime management to rtos::Thread
… from d65b6b0..b1c9efb b1c9efb Fix coap_connection_handler_send_data() return values (ARMmbed#81) f9cb04f Delete transaction when not needed (ARMmbed#80) daf3694 Message transaction memory handling changes (ARMmbed#79) adc04c4 Add API to send response to request based on Message ID (ARMmbed#78) 58f0ed5 Limit number of ongoing handshakes (ARMmbed#77) 42c1169 Fix redefinition of mbed TLS error codes (ARMmbed#76) ba7a7c4 Added server mode certificate conf (ARMmbed#74) d108199 Certificate set API changed. (ARMmbed#73) 2d622e0 Support for certificate mode (ARMmbed#72) git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service git-subtree-split: b1c9efb
* Update Jenkinsfile * Slow down sending of mbedgt commands So that the device serial buffer doesn't overflow
…c358..dd98c37 dd98c37 Merge pull request ARMmbed#85 from ARMmbed/sync_with_MbedOS 8418f4c (via Mbed OS) Add missing mbed_lib.json for frameworks and nanostack eb0692e Merge pull request ARMmbed#84 from ARMmbed/nslist_iar7 7ce58bf Support C++03 compilers that cannot return properly-typed pointers. 2775dce Merge pull request ARMmbed#83 from ARMmbed/IOTTHD-3187 fef3c6d Remove references to yotta a953636 Avoid memcmp(x, NULL, 0) 1de4b47 (split) Fix C++11 build with Arm Compiler 6 (ARMmbed#79) git-subtree-dir: features/frameworks/nanostack-libservice git-subtree-split: dd98c37c363acd0b6547ca59adc735ee52b2a7b1
Fix return values on some error conditions
Updating mbed-os to mbed-os-5.4.5
Remaining differences now are
Don't really understand the changes in pwmout_api.c? what's the reason that P1_6, P1_7, P1_1, P1_2, P1_3 are removed in LPC11XX? It looks like the differences between to the code are bugfixes that were not ported to the LPC11CXX. The relevant changes are in d0d2df3 (by Toyomasa Watarai), maybe he can comment.
PinNames needs to be updated according to the following differences:
The SWDIO/SWCLK definition can be the same for both targets: Would it be an idea to leave them in the peripheral api's but disable them from being used in pinmap.c? Or would you rather pretend that they don't exist at all?
It could be something like: