Add new target BLE Smurfs and fix Arch BLE export templates #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested the uvision4 and version 5 with the template for SMURFS? |
|
Only tested with uvision 4. I don't have a uvision 5 yet |
0xc0170
added a commit
that referenced
this pull request
Dec 19, 2014
Add new target BLE Smurfs and fix Arch BLE export templates
| @@ -12,7 +12,7 @@ | |||
| <ToolsetName>ARM-ADS</ToolsetName> | |||
| <TargetOption> | |||
| <TargetCommonOption> | |||
| <Device>nRF51xxx</Device> | |||
| <Device>nRF51822_xxAA</Device> | |||
There was a problem hiding this comment.
uv4 version 4.74 comes with support for nRF51xxx. why change the device to one not supported by the tool with the original installation?
There was a problem hiding this comment.
Thanks for pointing it out.
It is for that people with early uvision + Nordic SDK would not work with <Device>nRF51xxx</Device>. I will try to upgrade the uvision to test.
|
There are changes made here that wont work out of the box with default installations. Please consider the path someone would take for the first time using these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.